Fix incorrect translation for AtomicCmpExchangeWeak builtin ptr arg type.#3390
Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom Oct 16, 2025
Merged
Conversation
svenvh
approved these changes
Oct 15, 2025
MrSidims
approved these changes
Oct 16, 2025
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
maarquitos14
pushed a commit
to maarquitos14/SPIRV-LLVM-Translator
that referenced
this pull request
Oct 16, 2025
…ype. (KhronosGroup#3390) Add missing case so that pointer argument types for `OpAtomicCompareExchangeWeak` are resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing case so that pointer argument types for
OpAtomicCompareExchangeWeakare resolved correctly. The newly added test, without this patch would introduce an invalid bitcast just before the atomic builtin.